Refactor: merge duplicate HasTypeVars query visitors #18222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Dec 1, 2024
Collaborator
|
🧹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy.checkexpr.HasTypeVarQueryhas only one usage and is virtually1 identical tomypy.types.HasTypeVars. Merging them seems sensible. The latter has wider usage viahas_type_vars, so it seems like the better one to keep.Some history for the record:
mypy.checkexpr.HasTypeVarQuerywas added in 12 years ago a40efb4mypy.types.HasTypeVarswas added 5 years ago in 59617e8Footnotes
the only difference is that
HasTypeVarssetsself.skip_alias_target = True, but this seem to fit the usage ofHasTypeVarQueryjust as well. ↩